firefox-ios icon indicating copy to clipboard operation
firefox-ios copied to clipboard

Update the title label of the TabCell consistently when moving the tabs around

Open data-sync-user opened this issue 1 year ago • 3 comments

Behavior:

  1. Enable TabTrayFlagManager to return true
  2. Move the tabs
  3. Observe the TabCell label (image) does not update consistently

Expected Result: The image and title updates to show the image and title correctly every time you move the tab to a new location in the tab tray.

The part that does not update when moved is marked below:

!image-20240209-192902.png|width=1290,height=2796!

!Simulator Screen Recording - iPhone 15 Plus - 2024-02-09 at 11.27.26.mp4|width=1290,height=2796!

┆Issue is synchronized with this Jira Task

data-sync-user avatar Feb 07 '24 01:02 data-sync-user

Hi, How can I see the screen recording of the simulator?

Prathameshchakote avatar Feb 10 '24 08:02 Prathameshchakote

GitHub issue doesn't support this screen recording format (.qt) so I can't attach it. But know that this isn't marked as "Contributor OK" since this issue relates to a bug for some tab tray changes that are under development. It hasn't been released, nor is accessible unless you specifically make changes to access it from the codebase.

lmarceau avatar Feb 13 '24 18:02 lmarceau

ok Thank you

Prathameshchakote avatar Feb 13 '24 20:02 Prathameshchakote

➤ Diana Andreea Barladeanu commented:

Verified as fixed on v9000 (41759), with iPhone 15 (17.4).

I confirm that the tab titles look ok.

!RPReplay_Final1715601450.mp4|width=590,height=1280,alt="RPReplay_Final1715601450.mp4"!

data-sync-user avatar May 13 '24 11:05 data-sync-user

➤ Diana Andreea Barladeanu commented:

Verified as fixed on v126.1 (41973), with iPhone 15 (17.4).

data-sync-user avatar May 21 '24 08:05 data-sync-user