firefox-ios icon indicating copy to clipboard operation
firefox-ios copied to clipboard

Fix contentEdgeInsets in FakespotMessageCardView

Open data-sync-user opened this issue 2 years ago • 7 comments

LinkButton and primaryButton are subclass of LegacyResizableButton. They should instead be

  • LinkButton should be a subclass of LinkButton from the ComponentLibrary
  • primaryButton should be a subclass of PrimaryRoundedButton from the ComponentLibrary
  • All contentEdgeInsets and other warnings should be fixed
  • Add screenshots of your changes before/after on the PR
⚠️  'contentEdgeInsets' was deprecated in iOS 15.0: This property is ignored when using UIButtonConfiguration
        roundedButton.contentEdgeInsets = UIEdgeInsets(

┆Issue is synchronized with this Jira Task

data-sync-user avatar Nov 06 '23 16:11 data-sync-user

➤ Alina Moldovan commented:

Winnie Teichmann could you please add more details for the QA team to know what should test here?

data-sync-user avatar Jan 18 '24 12:01 data-sync-user

➤ Winnie Teichmann commented:

Alina Moldovan please check that the buttons of Report back in Stock card and Re-analysis card look correct and are accessible.

data-sync-user avatar Jan 18 '24 13:01 data-sync-user

➤ Diana Andreea Barladeanu commented:

Validated on v123(38163), with iPhone 15 (17.0).

The re-analysis card looks correct and is accessible.

The “Report back in stock” button is accessible, but it has an incorrect font color in dark mode. It is white instead of black.

!dark.jpeg|width=295,height=640!

data-sync-user avatar Jan 29 '24 13:01 data-sync-user

@bmihai23 would you might having a look into last comment?

Here's the attached image dark

lmarceau avatar Jan 29 '24 18:01 lmarceau

@lmarceau, I checked and run the app on two versions of iOS 17 and this is how it looks. I didn't find anything suspect in my code

Screenshot 2024-01-29 at 8 34 43 PM

bmihai23 avatar Jan 29 '24 18:01 bmihai23

@alinamoldovan84 could you help us to know what would need to change here? Thank you 🙏

lmarceau avatar Jan 29 '24 18:01 lmarceau

➤ Alina Moldovan commented:

The “Report back in Stock“ button is not displayed correctly while the device is in dark mode. The text is displayed on white instead of black.

Please see the attached screenshot:

!image-20240130-130611.png|width=364,height=446!

image

Please note that the issue reproduces in both nightly and 123 beta builds.

data-sync-user avatar Jan 30 '24 13:01 data-sync-user

➤ Winnie Teichmann commented:

Alina Moldovan The screenshot you posted looks exactly like the card should look like in dark mode according to Figma ( https://www.figma.com/file/VE5xayz3yOSB5qOATUU9Im/Mobile-Shopping-Experience-MVP?type=design&node-id=5283-77854&mode=dev ). The button text should be white in light and dark mode.

data-sync-user avatar Feb 20 '24 17:02 data-sync-user