firefox-ios icon indicating copy to clipboard operation
firefox-ios copied to clipboard

Published 20 hours ago • verified publisher icon mozilla-mobile

Fix deprecation warnings in inactive tab area

Open data-sync-user opened this issue 2 years ago • 4 comments

We have deprecation warnings in the inactive tab area - more specifically in InactiveTabItemCellModel, InactiveTabHeader and CellWithRoundedButton. Currently Inactive Tabs are not adjusting correctly to Dynamic Text changes as the layout is done with fixed cell heights. This needs to be adjusted before the deprecation warnings can be addressed.

┆Issue is synchronized with this Jira Task

data-sync-user avatar Nov 24 '22 19:11 data-sync-user

➤ Winnie Teichmann commented:

This should be on hold until we drop iOS 13.

data-sync-user avatar Feb 24 '23 22:02 data-sync-user

Hello, I would like to work on this task if it's available. Thank you!

bmihai23 avatar Oct 25 '23 09:10 bmihai23

@bmihai23 thanks for wanting to fix this. The team is currently working on a refactor in this area which should fix this task as well. For that reason I removed the Contributor OK label from this task.

thatswinnie avatar Oct 25 '23 11:10 thatswinnie

➤ Laurie Marceau commented:

FYI this will be fixed once the Legacy tab tray is removed from the project.

data-sync-user avatar Feb 14 '24 22:02 data-sync-user