Add #11305 [v106]: Synced tab in JumpBackIn CFR

Open nishant2718 opened this issue 2 years ago • 3 comments

#11305 | FXIOS-4566

This PR adds the Synced tab CFR. Some logic for JumpBackIn CFR was also impacted.

PENDING:

Check the guarantee (lack of, really) of CFR presentation order
Proposal of an AppSessionManager, for accessing isHomeTabBannerDisplayed elsewhere

Aug 06 '22 23:08 nishant2718

Apparently, the JumpBackIn CFR should show at the same time the HomeTabBanner is displayed..?

Need to double check that with Product.

Aug 08 '22 11:08 nishant2718

This PR is on hold. There are some complexities we need to go over before we can move forward.

Aug 09 '22 16:08 nishant2718

This pull request has conflicts when rebasing. Could you fix it @nishant2718?

Aug 09 '22 20:08 mergify[bot]

BR passed, and updated only with a SwiftLint fix after this.

Aug 12 '22 13:08 nishant2718