firefox-ios icon indicating copy to clipboard operation
firefox-ios copied to clipboard

Change up the nimbus-fml.sh script and split up the nimbus.fml.yaml file.

Open jhugman opened this issue 3 years ago • 1 comments

This PR is not ready to merge, but for when firefox-ios takes the (currently unreleased) upgrade which contains the EXP-2333 epic implementing the FML Imports and Includes proposal.

This PR does not go very far in splitting up the nimbus.fml.yaml file; I could go further, but would like to get some feedback before proceeding.


Thank you for submitting a pull request, your contributions are greatly appreciated!

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Please make sure you've run the test scheme and all the tests pass. If your changes affect existing tests please make sure to update the tests as well.

Below is the PR naming guidelines we follow:

https://github.com/mozilla-mobile/firefox-ios/wiki/Pull-Request-Naming-Guide

jhugman avatar Jul 13 '22 18:07 jhugman

This pull request has conflicts when rebasing. Could you fix it @jhugman?

mergify[bot] avatar Aug 09 '22 17:08 mergify[bot]

This pull request has conflicts when rebasing. Could you fix it @jhugman?

mergify[bot] avatar Sep 23 '22 17:09 mergify[bot]

Will test & review today.

adudenamedruby avatar Oct 19 '22 13:10 adudenamedruby

BR is green. Screen Shot 2022-10-19 at 3 42 22 PM

adudenamedruby avatar Oct 19 '22 19:10 adudenamedruby