fenix
fenix copied to clipboard
For #26577 - resetFocus only when camera permission is denied
resetFocus()
only when the Camera permission is not granted otherwise it reopen the keyboard when scanning.
Pull Request checklist
- [ ] Tests: This PR includes thorough tests or an explanation of why it does not
- [ ] Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [ ] Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.
QA
- [x] QA Needed
To download an APK when reviewing a PR (after all CI tasks finished running):
- Click on
Checks
at the top of the PR page. - Click on the
firefoxci-taskcluster
group on the left to expand all tasks. - Click on the
build-debug
task. - Click on
View task in Taskcluster
in the newDETAILS
section. - The APK links should be on the right side of the screen, named for each CPU architecture.
GitHub Automation
Fixes #26577
No Taskcluster jobs started for this pull request
The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request.
Hi,
Since it was a one liner I kept description to a minimum. On the PR checks
- I do not believe there is a test matching this scenario
- On screenshots, this change prevent the opening of the keyboard as seen in #26577
- No change on the accessibility part
As long as there is no conflict I intended to rebase the branch after feedbacks. Do you need any other information ?