fenix icon indicating copy to clipboard operation
fenix copied to clipboard

Published 20 hours ago • verified publisher icon mozilla-mobile

For #26833 - Make `Show all` button from homescreen header accessible with Talkback

Open Alexandru2909 opened this issue 2 years ago • 2 comments

Show all button from the homescreen headers should now be accessible in Talkback.

Before After
v1 v3

Ripple effect light:

Before After
https://user-images.githubusercontent.com/35462038/191580656-c5361c17-88d4-47af-adc1-15576ce8a911.mp4 https://user-images.githubusercontent.com/35462038/191580842-c4c51738-7bce-4373-b0df-3692bcdcdc18.mp4

Ripple effect dark:

Before After
https://user-images.githubusercontent.com/35462038/191581050-15144cdb-e49c-477d-9c7c-2fec5be4ae0e.mp4 https://user-images.githubusercontent.com/35462038/191581101-a3d27949-6e17-4e6f-bd3d-cc99f91600c6.mp4

This PR should also fix https://github.com/mozilla-mobile/fenix/issues/23570.

Pull Request checklist

  • [ ] Tests: This PR includes thorough tests or an explanation of why it does not
  • [x] Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • [x] Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

QA

  • [x] QA Needed

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-debug task.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Fixes #26833

Alexandru2909 avatar Sep 08 '22 15:09 Alexandru2909

This pull request has conflicts when rebasing. Could you fix it @Alexandru2909? 🙏

mergify[bot] avatar Sep 09 '22 16:09 mergify[bot]

Separately, the click area looks a little off currently: image

Switching the Box + BasicText to a TextButton may fix this for us.

MozillaNoah avatar Sep 20 '22 17:09 MozillaNoah

Tagged UX to check if the ripple effect and the padding for the header is expected.

Alexandru2909 avatar Oct 11 '22 11:10 Alexandru2909

This pull request has conflicts when rebasing. Could you fix it @Alexandru2909? 🙏

mergify[bot] avatar Nov 22 '22 00:11 mergify[bot]