fenix icon indicating copy to clipboard operation
fenix copied to clipboard

Implement Themed App Icon

Open mduchev opened this issue 2 years ago • 4 comments

What is the user problem or growth opportunity you want to see solved?

Since the 1st/2nd Android 13 beta, Google has been pushing the new Themed App Icons. We've already seen several apps adapting this new styling (e.g. 1Password 8, Reddit, etc). I know that it's a bit early to have this change inside Firefox, but the official Android 13 release is almost here, so we have to think of implementing it at some point. The APIs for Android 13 have been finalized, so this for sure will make it into the release.

How do you know that this problem exists today? Why is this important?

Firefox, like many other apps, hasn't implemented the new icon. It would be good at some point to have this new styling come to Firefox on Android as well, since it would increase the UI/UX.

Who will benefit from it?

All users running Android 13+

┆Issue is synchronized with this Jira Task

mduchev avatar Aug 02 '22 12:08 mduchev

Pretty please? It's the only app on my phone's home screen that doesn't match the theme!

MEXISNAKE avatar Sep 01 '22 04:09 MEXISNAKE

Excited to see 🔥🦊 in monochrome icon

bruuteforce avatar Sep 10 '22 04:09 bruuteforce

+1 from me, currently using Chrome browser on my phone to match my home screen theme, but would love to make the switch back to Firefox as my default app.

JordanDChappell avatar Sep 11 '22 01:09 JordanDChappell

UX would need to provide a monchrome icon resource for this.

mcarare avatar Sep 19 '22 14:09 mcarare

Isn't there already one? Just looking on the logo section of Mozilla design guidelines the Firefox logo zipfile has a Fx-Browser-icon-oneColor.svg which seems to be exactly what this feature would need. Fx-Browser-icon-oneColor.png

coolreader18 avatar Oct 01 '22 06:10 coolreader18

For UX evaluation, this is what it would look like, with tint adapted to the current OS wallpaper:

Notice the other icons for comparison.

mcarare avatar Oct 03 '22 16:10 mcarare

from design systems: Here should be all assets to make this happen at the right sizes. This includes assets to do the adaptive color and adaptive shape as well following this template: https://www.figma.com/file/rPjPBDNz95wRi501zppMwy/Android-App-Icons-(Community)?node-id=0%3A1 Android Themed App Icons.zip

lime124 avatar Oct 18 '22 22:10 lime124

Hoping for this soon and a UI overhaul to fix Fenix honestly awful UI. Google Chrome got the themed icon and Material You app design down and it's pretty solid of course, other than being you know, Google.

nyabinary avatar Oct 28 '22 22:10 nyabinary

updating label - lmk if you need anything else!

lime124 avatar Nov 04 '22 16:11 lime124

@lime124 How should the Beta/Nightly/Debug icons be handled? The debug icon seems fine to leave out (it's uncommon + making it stand out seems reasonable), but having installations of more than one of Release/Beta/Nightly and wanting them all to be themed seems like something that should be supported.

fice-t avatar Nov 14 '22 23:11 fice-t

@fice-t @lime124 and I talked through this and we currently can release the default icon as a themed option. The other icons would need some sort of badge to them but that is not possible for Android theming at the moment.

Currently Google themed icon docs don't have any info on adding a badge layer, and our beta and nightly icons are all the same shape.

jane-wolf avatar Nov 15 '22 00:11 jane-wolf

I would be happy to take the fix that works on release for now and file a followup to get some designs that work with the prerelease channels. It looks like Chrome beta creates a segment that divides the bottom of the circle and has the beta text.

kbrosnan avatar Nov 15 '22 01:11 kbrosnan

In the above commit, the monochrome icon is just the standard icon with the gradients and the globe in the middle removed. Imo this would be the most vanilla approach, but I think it might be worth considering a line style icon. Since this would be quite a far step from the current look, I wanted to ask here first and get some opinions. I'm thinking maybe we could just use the icons from LawnchairLaucher/lawnicons, as the licence should allow it. This would also solve the issue of separate icons for Beta, Nightly and Release.

Below are screenshots of the modified stock icon and the regular and beta variants of the lawnicons:

Screenshot_20221118_220528 Screenshot_20221118_223444 Screenshot_20221118_223605

fischer-felix avatar Nov 18 '22 21:11 fischer-felix

quick correction, forgot the official onecolor icon before, so her it is as well:

Screenshot_20221118_224632

fischer-felix avatar Nov 18 '22 21:11 fischer-felix

To be honest, I like both versions. However, I would lean towards using the solid icon so that it matches Pocket's icon design: obraz

nidmb avatar Nov 18 '22 22:11 nidmb

I like both icons as well, but I prefer the non-solid icon; it looks cleaner in my view. It also works more with other themed icons, such as Google-themed icons.

nyabinary avatar Nov 19 '22 21:11 nyabinary

The trend with the latest ones from Google (if it's anything to go by), namely Dialler, Messages and Contacts, seems to be preferring solid layers and negative colour for separating them. Overall, I think the solid variant would fit in better, but that might just be due to the icons I'm personally using.

Kernald avatar Nov 19 '22 22:11 Kernald

Solid seems like the best variant.

iamshilov avatar Nov 21 '22 18:11 iamshilov

So since solid seems to be the preferred option, I made a rough mock-up of how the beta and nightly badges could be implemented.

I'm not really happy with it myself, but can't really find what's bothering me. What do you think? ic_launcher_monochrome_beta_solid_red

fischer-felix avatar Nov 21 '22 20:11 fischer-felix

Rather than add that square, could the Fox not be hugging a circle with the letter B in? So it's kinda integrated into the current design in a more organic manner?

uniquePWD avatar Nov 21 '22 21:11 uniquePWD

Absolutely love the idea! Tried it with both Nightly and Beta, and it works quite well with an N, but the B looks a bit off (at least blown up when designing, now that I see it smaller in here, it might actually be fine when scaled down to icon size). ic_launcher_monochrome_nightly_solid_red ic_launcher_monochrome_beta_solid_hug_red Note: I know that the letters are a bit off-centre in there

fischer-felix avatar Nov 21 '22 21:11 fischer-felix

I like that a lot. Simple, clean and effective.

uniquePWD avatar Nov 21 '22 22:11 uniquePWD

Another option which might make the letters easier to identify could be to keep the letter in the bottom right corner, but use a similar negative space as a separation rather than the block you used in the previous iteration. That kind of negative space as separation is also what's used in recent Google icons, e.g. Messages and Contacts.

Note: I'm not using any other builds than the release one so I'm not sure what the current icons look like.

Kernald avatar Nov 21 '22 22:11 Kernald

I apologize in advance if this is considered inappropriate to ask in issues like this, I'm just new to following GH issues for Firefox. Is there a place to see the timeline of these sorts of issues, or if not, where are we on this one, I'm exited to see it released!

Otard95 avatar Nov 22 '22 07:11 Otard95

We are currently working out the best style for all icons, so once that's done I can file a pull request. From then on it depends on the maintainers and if they have anything they want changed.

I hope to have a finalized icon by the end of the week.

fischer-felix avatar Nov 22 '22 08:11 fischer-felix

Another option which might make the letters easier to identify could be to keep the letter in the bottom right corner, but use a similar negative space as a separation rather than the block you used in the previous iteration. That kind of negative space as separation is also what's used in recent Google icons, e.g. Messages and Contacts.

Note: I'm not using any other builds than the release one so I'm not sure what the current icons look like.

So you mean sort of like this?

ic_launcher_monochrome_nightly_red ic_launcher_monochrome_beta_red

fischer-felix avatar Nov 22 '22 11:11 fischer-felix

That's exactly what I had in mind indeed!

Kernald avatar Nov 22 '22 20:11 Kernald

hi all, our design systems team will reconvene and choose the style that works best for these additional logos. Since this impacts a brand logo, it may need to go through some approvals. With it being a holiday in the U.S this week we will get back to you with an ETA on Monday for any approvals needed.

jane-wolf avatar Nov 23 '22 23:11 jane-wolf

These mock-ups look great! What about the Fennec F-droid icon? I like the Fennec logo quite a lot, but I'd prefer an adaptive icon even if it's the same as the standard Firefox icon.

edit: I'm not sure if the Fennec icon is sourced from the fenix repo, or if it's added by the F-droid packagers. If this is out of scope, I apologize.

NathanC avatar Nov 24 '22 07:11 NathanC

If the packagers apply their own patches to the codebase it's up to them if they want to keep the standard adaptive icon ore change it. If they don't explicitly change it, the icon should be the same as upstream.

fischer-felix avatar Nov 25 '22 17:11 fischer-felix