fenix icon indicating copy to clipboard operation
fenix copied to clipboard

Published 20 hours ago • verified publisher icon mozilla-mobile

For #25722 - Refactor tabs tray interactors into one interactor

Open MozillaNoah opened this issue 2 years ago • 6 comments

Pull Request checklist

  • [ ] Tests: This PR includes thorough tests or an explanation of why it does not
  • [ ] Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • [ ] Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

QA

  • [x] QA Needed

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-debug task.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Fixes #25722

MozillaNoah avatar Jul 05 '22 23:07 MozillaNoah

This pull request has conflicts when rebasing. Could you fix it @MozillaNoah? 🙏

mergify[bot] avatar Jul 19 '22 17:07 mergify[bot]

Hey there! I'm sorry to jump in this PR. I'm just rebasing it because https://github.com/mozilla-mobile/fenix/pull/26073 reached main. It renamed the expected check from pr-complete to complete-pr. This impacts mergify and it may prevent you from merging this PR. That's why the rebase is needed. Let me know if you have any questions.

JohanLorenzo avatar Jul 20 '22 14:07 JohanLorenzo

This pull request has conflicts when rebasing. Could you fix it @MozillaNoah? 🙏

mergify[bot] avatar Aug 09 '22 21:08 mergify[bot]

getting an intermittent failure on TEST: WHEN record is called THEN telemetry is recorded with the appropriate label

retrying build

MozillaNoah avatar Aug 11 '22 21:08 MozillaNoah

This pull request has conflicts when rebasing. Could you fix it @MozillaNoah? 🙏

mergify[bot] avatar Sep 09 '22 16:09 mergify[bot]

This pull request has conflicts when rebasing. Could you fix it @MozillaNoah? 🙏

mergify[bot] avatar Sep 21 '22 20:09 mergify[bot]

This pull request has conflicts when rebasing. Could you fix it @MozillaNoah? 🙏

mergify[bot] avatar Sep 24 '22 00:09 mergify[bot]

This PR is a little old and became a bit unwieldy, so I'm closing this in favor of opening some newer, smaller PRs which cover the refactor pain points covered here.

MozillaNoah avatar Dec 06 '22 20:12 MozillaNoah