fenix icon indicating copy to clipboard operation
fenix copied to clipboard

Published 20 hours ago • verified publisher icon mozilla-mobile

For #25808: Build with compileSdkVersion for Android 13 / API 33.

Open mcarare opened this issue 2 years ago • 5 comments

Needs https://github.com/mozilla-mobile/android-components/pull/12396 to be merged first.

Pull Request checklist

  • [ ] Tests: This PR includes thorough tests or an explanation of why it does not
  • [ ] Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • [ ] Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

Fixes #25808 Fixes #25808 Fixes #25808 Fixes #25808 Fixes #25808

mcarare avatar Jul 04 '22 15:07 mcarare

For the moment this is blocked by https://issuetracker.google.com/issues/237725966.

mcarare avatar Jul 05 '22 12:07 mcarare

For the moment this is blocked by https://issuetracker.google.com/issues/237725966.

This will be fixed in a Navigation 2.5.1 bug fix release. It might involve needing to upgrade some other libraries.

mcarare avatar Jul 11 '22 07:07 mcarare

As it involves multiple dependency updates and presumably a lot of breaking changes, I am going to break out updating to navigation 2.5.1 (only 2.5.0 currently available) into a separate issue. Also, that keeps this PR clean, in the unlikely case of changes in 2.5.1. to suppress deprecations in generated safe args code will be backported.

mcarare avatar Jul 11 '22 15:07 mcarare

Hey there! I'm sorry to jump in this PR. I'm just rebasing it because https://github.com/mozilla-mobile/fenix/pull/26073 reached main. It renamed the expected check from pr-complete to complete-pr. This impacts mergify and it may prevent you from merging this PR. That's why the rebase is needed. Let me know if you have any questions.

JohanLorenzo avatar Jul 20 '22 14:07 JohanLorenzo

DIsabled 3 UI tests that pass on other devices and work as expected in real app usage. Opened https://github.com/mozilla-mobile/fenix/issues/27865 for investigating and possibly re-enabling the tests.

mcarare avatar Nov 16 '22 16:11 mcarare