android-components icon indicating copy to clipboard operation
android-components copied to clipboard

Add dispatcher for keyboard shortcuts

Open gaul opened this issue 4 years ago • 3 comments

References #1978.

Pull Request checklist

  • [ ] Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • [ ] Tests: This PR includes thorough tests or an explanation of why it does not
  • [ ] Changelog: This PR includes a changelog entry or does not need one
  • [ ] Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

This is more of a proof-of-concept to show interest and ask for help. @samlh @pocmo could you give me guidance on how this might be implemented in a more extensible way? I understand that this should be sending these events to the embedding application so it can call things like components.useCases.sessionUseCases.reload() but I'm not sure where to start.

gaul avatar Mar 21 '21 14:03 gaul

Codecov Report

Merging #9948 (97b802f) into master (055736c) will decrease coverage by 8.37%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #9948      +/-   ##
============================================
- Coverage     74.00%   65.63%   -8.38%     
+ Complexity     5665      269    -5396     
============================================
  Files           778       94     -684     
  Lines         28831     2258   -26573     
  Branches       4741      363    -4378     
============================================
- Hits          21337     1482   -19855     
+ Misses         5013      618    -4395     
+ Partials       2481      158    -2323     
Impacted Files Coverage Δ Complexity Δ
...main/java/mozilla/components/service/fxa/Config.kt
...omponents/feature/prompts/provider/FileProvider.kt
...owser/session/engine/middleware/CrashMiddleware.kt
...s/browser/icons/processor/AdaptiveIconProcessor.kt
...ponents/browser/icons/preparer/DiskIconPreparer.kt
...ents/browser/session/ext/BrowserStoreExtensions.kt
...illa/components/feature/prompts/PromptContainer.kt
...ava/mozilla/components/browser/menu/BrowserMenu.kt
...va/mozilla/components/service/fxa/manager/State.kt
...n/java/mozilla/components/service/pocket/Logger.kt
... and 674 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 055736c...97b802f. Read the comment docs.

codecov[bot] avatar Mar 21 '21 15:03 codecov[bot]

This pull request has conflicts when rebasing. Could you fix it @gaul? 🙏

mergify[bot] avatar Apr 20 '21 18:04 mergify[bot]

This pull request has conflicts when rebasing. Could you fix it @gaul? 🙏

mergify[bot] avatar Sep 23 '22 20:09 mergify[bot]