android-components icon indicating copy to clipboard operation
android-components copied to clipboard

Published 20 hours ago • verified publisher icon mozilla-mobile

Disable find in page for empty queries

Open ionutbedregeanu opened this issue 3 years ago • 2 comments

For #12637 Disable find in page for previous and forward buttons if the query is empty

https://user-images.githubusercontent.com/11731652/184190411-703c8d8f-b51c-4d6d-9b88-bfb977992615.mp4

Pull Request checklist

  • [x] Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • [x] Tests: This PR includes thorough tests or an explanation of why it does not
  • [x] Changelog: This PR includes a changelog entry or does not need one
  • [x] Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

GitHub Automation

Fixes #12637

ionutbedregeanu avatar Aug 11 '22 16:08 ionutbedregeanu

This pull request has conflicts when rebasing. Could you fix it @ionutbedregeanu? 🙏

mergify[bot] avatar Aug 11 '22 16:08 mergify[bot]

I think we need to update tests to adapt to the new behaviour that we are adding :)

[task 2022-08-12T05:35:35.587Z]   TEST: Clicking previous button invokes onPreviousResult method of listener
[task 2022-08-12T05:35:35.687Z]     E/ThemeUtils: View class androidx.appcompat.widget.AppCompatImageButton is an AppCompat widget that can only be used with a Theme.AppCompat theme (or descendant).
[task 2022-08-12T05:35:35.687Z]     E/ThemeUtils: View class androidx.appcompat.widget.AppCompatImageButton is an AppCompat widget that can only be used with a Theme.AppCompat theme (or descendant).
[task 2022-08-12T05:35:35.687Z]     E/ThemeUtils: View class androidx.appcompat.widget.AppCompatImageButton is an AppCompat widget that can only be used with a Theme.AppCompat theme (or descendant).
[task 2022-08-12T05:35:35.787Z]   FAILURE

[task 2022-08-12T05:35:35.888Z]   TEST: Clicking next button invokes onNextResult method of listener
[task 2022-08-12T05:35:35.888Z]     E/ThemeUtils: View class androidx.appcompat.widget.AppCompatImageButton is an AppCompat widget that can only be used with a Theme.AppCompat theme (or descendant).
[task 2022-08-12T05:35:35.987Z]     E/ThemeUtils: View class androidx.appcompat.widget.AppCompatImageButton is an AppCompat widget that can only be used with a Theme.AppCompat theme (or descendant).
[task 2022-08-12T05:35:35.987Z]     E/ThemeUtils: View class androidx.appcompat.widget.AppCompatImageButton is an AppCompat widget that can only be used with a Theme.AppCompat theme (or descendant).
[task 2022-08-12T05:35:35.987Z]   FAILURE

Amejia481 avatar Aug 12 '22 14:08 Amejia481

This pull request has conflicts when rebasing. Could you fix it @ionutbedregeanu? 🙏

mergify[bot] avatar Aug 22 '22 16:08 mergify[bot]

Glean probe-scraper is failing

ionutbedregeanu avatar Aug 24 '22 04:08 ionutbedregeanu