android-components icon indicating copy to clipboard operation
android-components copied to clipboard

Bug 1783843 - Remove the workaround to support Glean in libs

Open Dexterp37 opened this issue 2 years ago • 0 comments

The Glean SDKs now corrently deal with missing VERSION_CODE and VERSION_NAME fields in BuildConfig. See https://bugzilla.mozilla.org/show_bug.cgi?id=1713084. This workaround is no longer needed.

Pull Request checklist

  • [ ] Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • [ ] Tests: This PR includes thorough tests or an explanation of why it does not
  • [ ] Changelog: This PR includes a changelog entry or does not need one
  • [ ] Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

GitHub Automation

Used by GitHub Actions.

Dexterp37 avatar Aug 09 '22 10:08 Dexterp37