android-components icon indicating copy to clipboard operation
android-components copied to clipboard

Published 20 hours ago • verified publisher icon mozilla-mobile

For #12378: Build with compileSdkVersion for Android 13 / API 33.

Open mcarare opened this issue 3 years ago • 6 comments

Pull Request checklist

  • [x] Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • [x] Tests: This PR includes thorough tests or an explanation of why it does not
  • [ ] Changelog: This PR includes a changelog entry or does not need one
  • [x] Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

Fixes #12378

Fixes #12378 Fixes #12378

mcarare avatar Jun 27 '22 15:06 mcarare

This pull request has conflicts when rebasing. Could you fix it @mcarare? 🙏

mergify[bot] avatar Jul 20 '22 15:07 mergify[bot]

This pull request has conflicts when rebasing. Could you fix it @mcarare? 🙏

mergify[bot] avatar Aug 12 '22 13:08 mergify[bot]

This pull request has conflicts when rebasing. Could you fix it @mcarare? 🙏

mergify[bot] avatar Sep 08 '22 14:09 mergify[bot]

bors try

mcarare avatar Oct 11 '22 16:10 mcarare

Can you spin out the ktlint change as a separate PR that we can land later? Since there's already numerous code changes, I don't think we should include ktlint changes in this PR.

gabrielluong avatar Oct 11 '22 17:10 gabrielluong

try

Timed out.

bors[bot] avatar Oct 11 '22 19:10 bors[bot]

Can you spin out the ktlint change as a separate PR that we can land later? Since there's already numerous code changes, I don't think we should include ktlint changes in this PR.

I could regenerate the baseline to include the new issues (or update references), but that would kind of defeat the purpose of a baseline (if we keep changing it, instead of fixing the issues).

mcarare avatar Oct 12 '22 06:10 mcarare

bors try

mcarare avatar Oct 12 '22 07:10 mcarare

try

Timed out.

bors[bot] avatar Oct 12 '22 10:10 bors[bot]

This pull request has conflicts when rebasing. Could you fix it @mcarare? 🙏

mergify[bot] avatar Oct 17 '22 21:10 mergify[bot]

This pull request has conflicts when rebasing. Could you fix it @mcarare? 🙏

mergify[bot] avatar Oct 26 '22 12:10 mergify[bot]

Hey @mcarare This project moved to a new repository. It is now developed and maintained at: https://github.com/mozilla-mobile/firefox-android

gabrielluong avatar Oct 31 '22 16:10 gabrielluong