android-components icon indicating copy to clipboard operation
android-components copied to clipboard

[Bug]: [a11y] BrowserMenuImageTextCheckboxButton item

Open bigConifer opened this issue 2 years ago • 1 comments

See https://github.com/mozilla-mobile/fenix/issues/24560

For the Bookmarks Menu item with integrated Add/Edit button the BrowserMenuItem called BrowserMenuImageTextCheckboxButton is used (introduced in #9943).

However there is an accessibility bug, regarding the size of it's clickable areas.

If you click a little off the checkbox area (namely on the right, top or bottom of the checkbox) then the parent bookmarks menu item is clicked. That behavior is definitely not intended.

If users want to open the bookmarks list they will only click on the left where the label "Bookmarks" is and never on the right where the "Add/Edit" button is located.

Solution would be to extent the clickable area of the checkbox to the top, bottom and outer right end of its parent element. Therefore, also paddingEnd coming from @style/Mozac.Browser.Menu.Item.Container has to be removed for the mozac_browser_menu_item_image_text_checkbox_button layout.

┆Issue is synchronized with this Jira Task

bigConifer avatar Apr 04 '22 17:04 bigConifer

@mcarare As author of the underlying code, can you please explain what's the purpose of the accessibilityRegion element? It looks like it's redundant since the same listener is applied to the parent BrowserMenuItem as well as to this element.

It would be nice if you could reply briefly so that we can proceed with cleaning up the layout and fixing the issue.

bigConifer avatar Apr 04 '22 17:04 bigConifer

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1795115

Change performed by the Move to Bugzilla add-on.

csadilek avatar Oct 13 '22 19:10 csadilek