android-components icon indicating copy to clipboard operation
android-components copied to clipboard

SyncedTabsFeature is tightly coupled to an XML + Fragment UI implementation

Open MozillaNoah opened this issue 3 years ago • 2 comments

With SyncedTabs getting rewritten in https://github.com/mozilla-mobile/fenix/issues/21900, the original implementation of SyncedTabsFeature + SyncedTabsView doesn't translate 100% to a Composable world. We should find a better way to handle the data flow and interactions between the UI and SyncedTabsFeature that doesn't require this line, Observable<SyncedTabsView.Listener> by ObserverRegistry(), in SyncedTabsIntegration to unintuitively initialize SyncedTabsIntegration.listener in order to handle data refreshes and synced tab clicks (TabClickDelegate).

┆Issue is synchronized with this Jira Task

MozillaNoah avatar Jan 14 '22 18:01 MozillaNoah

Please see this comment whenever someone picks up this ticket: https://github.com/mozilla-mobile/fenix/pull/22798#discussion_r785258796

jonalmeida avatar Jan 15 '22 02:01 jonalmeida

Related ticket https://github.com/mozilla-mobile/fenix/issues/26049

MozillaNoah avatar Jul 19 '22 21:07 MozillaNoah

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1794231

Change performed by the Move to Bugzilla add-on.

jonalmeida avatar Oct 08 '22 02:10 jonalmeida