android-components
android-components copied to clipboard
SyncedTabsFeature is tightly coupled to an XML + Fragment UI implementation
With SyncedTabs getting rewritten in https://github.com/mozilla-mobile/fenix/issues/21900, the original implementation of SyncedTabsFeature
+ SyncedTabsView
doesn't translate 100% to a Composable world. We should find a better way to handle the data flow and interactions between the UI and SyncedTabsFeature
that doesn't require this line, Observable<SyncedTabsView.Listener> by ObserverRegistry()
, in SyncedTabsIntegration
to unintuitively initialize SyncedTabsIntegration.listener
in order to handle data refreshes and synced tab clicks (TabClickDelegate
).
┆Issue is synchronized with this Jira Task
Please see this comment whenever someone picks up this ticket: https://github.com/mozilla-mobile/fenix/pull/22798#discussion_r785258796
Related ticket https://github.com/mozilla-mobile/fenix/issues/26049
Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1794231
Change performed by the Move to Bugzilla add-on.