android-automation-tools icon indicating copy to clipboard operation
android-automation-tools copied to clipboard

Published 20 hours ago • verified publisher icon mozilla-mobile

Add tests, a sample, and support for consuming a local GeckoView.

Open ncalexan opened this issue 5 years ago • 6 comments

Pull Request checklist

  • [x] This PR includes thorough tests or an explanation of why it does not
  • [x] This PR includes a CHANGELOG entry or does not need one
  • [x] The tests are passing after this PR (./gradlew test; consider a pre-push hook)

ncalexan avatar Mar 21 '19 22:03 ncalexan

This really needs somebody else to vet my instructions, 'cuz it's subtle and easy to get wrong. Testing against r-b would be helpful, and/or against the a-c sample browser.

To test meaningfully you don't need a full Gecko build -- an artifact build works just fine. You can verify that you get the artifact build libxul.so pretty easily.

ncalexan avatar Mar 21 '19 22:03 ncalexan

See also ./gradlew app:dependencies and ./gradlew androidDependencies, which both will show substitutions from geckoview-nightly-$ARCH to geckoview-default-$LOCAL_ARCH.

ncalexan avatar Mar 21 '19 22:03 ncalexan

This is basically https://bugzilla.mozilla.org/show_bug.cgi?id=1533465 (really, https://phabricator.services.mozilla.com/D22552) but put into Gradle plugin form.

ncalexan avatar Mar 21 '19 22:03 ncalexan

I'll get to this on Monday (my brain is too fried).

mcomella avatar Mar 22 '19 23:03 mcomella

And by Monday, I mean tomorrow (Wednesday): sorry for my poor time scheduling.

mcomella avatar Mar 27 '19 00:03 mcomella

I'll try to build this locally and get back with my approval or request for changes.

I'm going to try that tomorrow morning, if that's okay with you: I want to do something else besides review code today. :P

mcomella avatar Mar 27 '19 23:03 mcomella