lockwise-ios icon indicating copy to clipboard operation
lockwise-ios copied to clipboard

autofilll is broken since 1.6.0

Open heubergen opened this issue 5 years ago • 111 comments

Steps to reproduce

Install app Login Activate the app as the only autofill service Open a login site (e.g. auth.netatmo.com) with Safari Click on the blue autofill button with your login on it OR Click on the key symbol and then choose the login from the list

Expected behavior

Login information are filled out

Actual behavior

Nothing happens

Device & build information

  • Device: iPhoneXs with iOS 12.3.1, Background App Refresh is deactivated
  • Build version: Currently app v1.6.2

Notes

It works if you choose in the menu the app (so that it opens) and manually click on the login. I'm almost sure it worked with the app version 1.6.0

heubergen avatar Jun 28 '19 16:06 heubergen

@heubergen to help troubleshoot this, can you please confirm if this still doesn't work as expected when you go into the iOS Settings application and disable then re-enable AutoFill (with Lockwise as the selected provider)?

devinreams avatar Jun 28 '19 17:06 devinreams

@devinreams have tried that and it didn't help either. The same results after the reactivation. And I also tried to logout of the app, removing the app and configure it all again.

Edit: If you there's any way for me to test it again with 1.6.0 I can confirm a regression.

heubergen avatar Jun 28 '19 17:06 heubergen

I can confirm the same behavior:

Device & build information

Device: iPhone SE with iOS 12.3.1 Build version: v1.6.2

andolivieri avatar Jun 29 '19 09:06 andolivieri

I am unable to reproduce this behavior using the steps above (iPhone X, iOS 12.3.1, app v1.6.2).

yuvalwolf avatar Jul 01 '19 18:07 yuvalwolf

Same here with iPhone 5S, iOS 12.3.1 & Lockwise 1.6.2.

natolh avatar Jul 02 '19 12:07 natolh

App version: 1.6.2 iOS version: 12.3.1 iPhone 7

Exactly same behavior. It is broken since the app was renamed as Lockwise. It was good before.

cagrist avatar Jul 08 '19 23:07 cagrist

No technical note but just want to load my frustration here: I have no idea if somebody is working on this or not, but I can't understand how in a stable product from Mozilla a core functionality can be broken for >15 days and no one seems to care! I switched the pw manager for now because of this.

heubergen avatar Jul 13 '19 10:07 heubergen

I agree wirh @heubergen on this. This feaure is core functionality!

Clicking this button does nothing by dhruvkb Clicking this button does nothing

Choosing Lockwise (2nd option) works by dhruvkb Choosing Lockwise (2nd option) and selecting the same account from the app works.

This has been broken since the rebranding. Please fix this. All other features and bugs can come after the main function of the app works as advertised.

It's been a long time since this issue arose.

dhruvkb avatar Jul 14 '19 17:07 dhruvkb

Tried to repo this on my iPhone 7 (12.3.1) and was able to get it into a similar state once by:

  1. Installing the app and enabling Autofill in settings
  2. Locking Lockwise
  3. Opening Settings->Touch ID & Passcode and Disabling "Password AutoFill"
  4. Opening Safari navigating to Github.com When I tap the blue button it does nothing.

I was able to "reset" this by:

  1. Opening Settings->AutoFill Passwords->
  2. Disable Lockwise
  3. Enable Lockwise

Haven't had much luck otherwise. There are two commits that seem like they could be related: https://github.com/mozilla-lockwise/lockwise-ios/commit/f9567116eb6c65d3464e6d905ae3c3d5e96e2a2b#diff-42a9face8036f09d6e628e20be7a5531 https://github.com/mozilla-lockwise/lockwise-ios/commit/a05728f2e301c22ae95fdc2404b4e82620cf4dab#diff-42a9face8036f09d6e628e20be7a5531

joeyg avatar Jul 14 '19 22:07 joeyg

I disabled and re-enabled Lockwise, got a message 'Updating AutoFill', disabled iCloud Keychain but after all this, the blue button still won't work.

dhruvkb avatar Jul 14 '19 23:07 dhruvkb

@dhruvkb ah. Ok. Thanks for checking that. If you unlock the app by launching Lockwise, set it to a timeout of like 5min in Settings and then try and use the password auto fill in safari does it work? I’m trying to narrow down the code that could be creating the issue.

joeyg avatar Jul 15 '19 00:07 joeyg

My lock timeout is set to Never.

dhruvkb avatar Jul 15 '19 02:07 dhruvkb

Hi. I can confirm this behavior has been happening for weeks. Config: iPhone X, iOS: 12.3.1, App Version 1.6.2

I tried signing out and back in but it had no effect, uninstalling reinstalling had no effect either. My lock timeout is also set to Never.

simonc avatar Jul 15 '19 07:07 simonc

@joeyg Just tried that by installing the app fresh and let the lock by 5 minutes. Auto fill is still broken. Hope that helps!

heubergen avatar Jul 18 '19 16:07 heubergen

Exactly same issue with heubergen. Have tried to re-enable lockwise in autofill settings and keep lockwise not locked, but lockwise still can't fill my password.

iPad Air 2019, iOS 12.3.1, Lockwise 1.6.2

Excited-ccccly avatar Jul 21 '19 04:07 Excited-ccccly

Very frustrating. I can’t believe this issue not fixed yet. Still broken on iPhone SE, iOS 12.3.1, Lockwise app 1.6.2 ☹️ Tried: Reinstalling Sign out / sign in Changing timeout

pinchies avatar Jul 23 '19 19:07 pinchies

No technical note but just want to load my frustration here: I have no idea if somebody is working on this or not, but I can't understand how in a stable product from Mozilla a core functionality can be broken for >15 days and no one seems to care! I switched the pw manager for now because of this.

It's very difficult to troubleshoot and subsequently fix an issue that isn't reproducible -- simply because we need to be able to recreate the condition that occurs. And so far, we've been unable to reproduce it.

I'm running 1.6.2 on the same iOS version and settings (but on an iPhone 7), and cannot reproduce this either. So we're 1 for 3 on attemptors at all, and joeyg's almost doesn't count because of the contortions required (which aren't present in the OP). We'll keep trying.

ddurst avatar Jul 24 '19 19:07 ddurst

I'm sorry if I was a bit harsh but for me it looked like nobody would take care of it. Maybe assign it to somebody or something like that would've helped.

Sorry that I can't help any further, if there is anything please let me know.

heubergen avatar Jul 24 '19 20:07 heubergen

I was just able to reproduce this once (for what it's worth, @joeyg). Here's what I did (site X for me was airtable):

0?. Disrupt sync by disabling "logins" from FxA sync settings on iOS. Sync appears to start and spins.

Then, having never been to site X on iOS, and having never saved site X's login on desktop...

  1. Lockwise is installed, FxA sync settings on iOS are all disabled.
  2. Save login for site X on desktop.
  3. Wait for sync to succeed, as evidenced by site X appearing in Lockwise (which I left running, fwiw).
  4. Launch Safari, go to site X.
  5. Attempt to use big blue button, nothing happens.
  6. Click on key icon (perhaps impatiently?), and select the top option in the menu (which is the lockwise credential). This works.
  7. Sign out.
  8. Go back to site X's sign-in form.
  9. The big blue button now works.

😕

ddurst avatar Jul 24 '19 20:07 ddurst

@ddurst thanks for the helpful report! This might be different than previous reports as the tapping the First option in the menu did not work for them. They needed to tap the second option which opens the Lockwise UI for it to work.

joeyg avatar Jul 24 '19 21:07 joeyg

Neither the big blue button, nor the first option ' for this website -- Lockwise' works for me. Tried reinstalling, disabling and re-enabling sync and also playing around with lock timings.

dhruvkb avatar Jul 25 '19 05:07 dhruvkb

Is there anything / anyway I can provide access to my account / device to help with reproducing this? I could do teamviewer to a laptop while streaming my device screen to the laptop?

pinchies avatar Jul 25 '19 05:07 pinchies

I think next steps are to get y’all a build on buddy build with logging. I’ll try and get a branch up with that.

joeyg avatar Jul 25 '19 14:07 joeyg

For what its worth, I had the same issue on a clean install iPhone, so I suspect something about this is account/content related.

pinchies avatar Jul 25 '19 14:07 pinchies

That would explain why it's hard to reproduce since it'd be a data issue, not a "conditions" issue. Could the date of creation the account, the version of Firefox in which the logins were saved, the number of saved passwords, or something like that have any impact? I'm just throwing ideas up in the air but sometimes… 💡 😁

Good luck in your research, let us know of there's anything we can do ❤️

simonc avatar Jul 25 '19 22:07 simonc

Well, I can narrow the scope a bit. In my tests, I used:

  • beta (69)
  • only two logins, both newly-created

ddurst avatar Jul 26 '19 15:07 ddurst

I'm really trying to be polite here, and this is not a personal attack, but I feel that perhaps your team is not giving this issue a high priority.

Here I am, I'm trusting the digital keys to some of my most personal information in my life, to a team who have been unable to properly troubleshoot and resolve a major show stopping bug in their app for well over a month.

What confidence do you think this gives me regarding the strength of your app security? What is going on? Is your team under resourced, are you all volunteers, or are there other higher priorities? The lack of communication is incredibly frustrating from a user perspective.

What do you need from us to help troubleshoot this issue? Is there anything we can do? I'm happy to do whatever I can to help.

I had this issue with the last version of the previous app too, before it was renamed lockwise.

pinchies avatar Aug 01 '19 03:08 pinchies

@pinchies sorry to hear this still isn’t working for you. I haven’t had time in my evenings to figure out what is going on - hopefully someone in the community or someone at Mozilla will have time soon to resolve it.

joeyg avatar Aug 01 '19 04:08 joeyg

I have found that when I click the suggested login details in the autofill popup - nothing happens. However, I have found that when I choose "Lockwise...", and use the selector modal popup to choose the desired account (can be the same one as was suggested) then the correct login details are passed through and filled in.

So this specifically seems to be something wrong with the actions that happen after tapping to select/accept the automatically suggested matching login accounts.

I note that at least for me, this is a different outcome than @dhruvkb had, where neither of the options worked. I previously tried both options and they both didn't work - so I would encourage @dhruvkb to try using the "Lockwise..." option again too.

pinchies avatar Aug 04 '19 13:08 pinchies

@pinchies Thanks for confirming my observation:

It works if you choose in the menu the app (so that it opens) and manually click on the login.

heubergen avatar Aug 04 '19 13:08 heubergen