lockwise-ios icon indicating copy to clipboard operation
lockwise-ios copied to clipboard

Published 20 hours ago • verified publisher icon mozilla-lockwise

Proper Attribution of Dependencies (license notices)

Open linuxwolf opened this issue 5 years ago • 5 comments

Information on the dependencies and their copyrights/licenses should be present in the software.

At the least, this repository should include the following information on the dependencies:

  • Name
  • Copyright Notice
  • License (reference)

There is discussion that it may need to be presentable to users of this software in some form.

Design

Description: The inclusion of a new menu item is also a new opportunity to reorganize this structure; I've made the following changes to the Settings list:

  • Change label of "Configuration" to "General"
  • Move the newly named "General" section to the top of the order stack
  • Create a new "About Section" at base of list, above "Lock Now"
  • Move the App Version to the "About Section"
  • Create a new "Licenses" subsection for containing the proper attribution of dependencies

Settings Section InVision: https://mozilla.invisionapp.com/share/BQEUSO0S2#/267560609_Settings_-_Touch_ID_Enabled Zeplin: https://zpl.io/VKNMd5W

Licenses Webview Invision: https://mozilla.invisionapp.com/share/BQEUSO0S2#/384809123_Settings_-_Licenses Zeplin: https://zpl.io/V0p3zrK

Note: There needs to be a responsive webview URL (location and build TBD) for housing all licenses, as Firefox has done for their licenses.

References

BMO 1548663 BMO 1561740

linuxwolf avatar May 24 '19 14:05 linuxwolf

@sandysage Firefox iOS just has all the licenses dumped into an HTML file that is linked from Settings (https://github.com/mozilla-mobile/firefox-ios/blob/master/Client/Assets/About/Licenses.html). Is that reasonable to do here?

joeyg avatar Jun 12 '19 04:06 joeyg

For A-S, we now include a list of dependencies in the repo here:

https://github.com/mozilla/application-services/blob/master/megazords/ios/DEPENDENCIES.md

It will be updated automatically if our set of dependencies changes (or rather, CI will prevent landing dependency updates without regenerating this file).

rfk avatar Jul 31 '19 06:07 rfk

@sandysage @ddurst I've updated the description above and have provided everything (I think) for us to begin development. Please review and prioritize accordingly :)

changecourse avatar Sep 19 '19 16:09 changecourse

It's also worth mentioning that the location, URL structure, and building of the responsive mobile page still need to be completed for this effort.

changecourse avatar Sep 19 '19 17:09 changecourse

LGTM

ddurst avatar Sep 21 '19 01:09 ddurst