lockwise-android icon indicating copy to clipboard operation
lockwise-android copied to clipboard

Workaround for IllegalStateException in autofill activity

Open Governa opened this issue 4 years ago • 1 comments

It seems that in Android 8.0.0 (API 26) there is a bug where setting the auto fill activity window to translucent causes an exception to be thrown. Per #1076 it doesn't happen on Android 8.1.

This patch works around the problem by not setting the window to be translucent on API 26 only. The window is (obviously) not translucent, but the App doesn't crash and is otherwise usable.

Fixes #1076 and #1157

Testing and Review Notes

Tested on a Galaxy S7 - Android 8.0.0

To Do

  • add “WIP” to the PR title if pushing up but not complete nor ready for review
  • [ ] double check the original issue to confirm it is fully satisfied
  • [ ] add testing notes and screenshots in PR description to help guide reviewers
  • [ ] add unit tests
    • optional: consider adding instrumentation (integration/UI) tests
  • consider running this branch in a debug simulator and check for memory leak notifications or any warnings
  • [x] request the "UX" team perform a design review (if/when applicable)
  • [ ] make sure CI builds are passing (e.g.: fix lint and other errors)
  • [x] check on the accessibility of any added UI

Governa avatar Jun 23 '20 16:06 Governa

This issue seems to impact many users, is there anything I can do to make merging this easier?

Yes, I am one of the impacted users and waiting eagerly for this fix to be able to use Lockwise :-)

Governa avatar Jul 22 '20 23:07 Governa