mozilla-aws-cli icon indicating copy to clipboard operation
mozilla-aws-cli copied to clipboard

Published 20 hours ago • verified publisher icon mozilla-iam

Unset environment variables more consistently.

Open smarnach opened this issue 3 years ago • 3 comments

We noticed that maws currently does not unset the AWS_SECURITY_TOKEN evnironment variable, which can lead to confusing behaviour if it is still set. This PR makes sure this env variable is always unset, and makes unsetting env vars overall a bit more consistent.

It's not tested at all, and probably needs unit tests, so this is still a draft.

smarnach avatar Sep 10 '21 16:09 smarnach

I think this is a good idea (unsetting those variables). This PR may be the way to do it, or maybe some other approach. Either way, ya we should introduce this change in some form.

gene1wood avatar Sep 10 '21 20:09 gene1wood

Hey @smarnach have you been running this locally for a while? It seems fine to me with your update.

bkochendorfer avatar Apr 04 '22 16:04 bkochendorfer

Yes, I ran this locally since I filed the PR, and didn't run into any issues.

smarnach avatar Apr 05 '22 14:04 smarnach