gaia
gaia copied to clipboard
mozilla-b2g
Bug 989964 - [proposal][feature] Duckduckgo as a search provider on Home...
...screen search/Everything.me
added DuckDuckGo as a search engine for the search bar. I must add that the suggestions url mentioned doesn't work.
Abhiram Chintangal (achintangal)
Great! As a user of Duckduckgo, I would really like to have it available on FxOS. May I suggest to switch to the HTTPS URL instead of HTTP? I know it "costs" a bit more CPU, but I believe that most Duckduckgo users would prefer privacy over a slight CPU overhead.
@mossroy I am glad you noticed . I will make the necessary changes and amend it.
Thanks @achintangal ! I saw that you switched to HTTPS for the urlTemplate Anyway, the suggestionsUrlTemplate is still on HTTP. If it's not working anyway, I would suggest to remove it or comment it (just my personal opinion) Using an http url for suggestions makes the search terms sent on the network in plain text, even if the suggestions don't work.
After a few searching, I did not find any HTTPS url that would allow suggestions from duckduckgo (the one you provided uses in fact Google engine, see http://ddgg.nfriedly.com/)
@mossroy The suggestionsUrlTemplate is one thing I didn't test when I initially made the changes. Later, one of the developers told me that suggestions themselves are yet to implemented. So I didn't modify it for consistency sake.
Either way, It makes sense to mention it somewhere. Can I comment in json files?
@achintangal : apparently there are no "comments" in json, even if there are workarounds : http://stackoverflow.com/questions/244777/can-i-comment-a-json-file
Maybe a compromise would be to leave your suggestionsUrlTemplate value, but change its protocol to https instead of http : https://ddgg.nfriedly.com/complete/search?json&q={searchTerms} Currently, this URL would fail because of an invalid SSL certificate But, at least, when FxOS implements suggestions, it will not leak the search terms in plain text. And the URL is still mentioned in the JSON
@mossroy
Makes sense if one were to consider it as only a data exchange format. With regard to suggestions, dgg currently provides the users with search suggestions but its seems to be performed internally. May be they will expose this in the future?
Anyways, I have updated the link to https and amended the commit
This pull request has been closed due to tree stability issues. Please rebase and re-open the pull request if you still need to land this. Ensure the gaia-try run is green before landing. Sorry for any inconvenience.
Kevin Grandon (KevinGrandon)