MultiComponentFlash.jl icon indicating copy to clipboard operation
MultiComponentFlash.jl copied to clipboard

Clapeyron Integration

Open longemen3000 opened this issue 4 years ago • 4 comments

Hi!

First, Sorry for the delay, i saw your comment on the Clapeyron issue, and i can code some integration between this package and Clapeyron, via an optional dependency (this is possible by using Requires.jl, that loads the Clapeyron code only if the module is loaded). can i ask any questions about the package here?

longemen3000 avatar Nov 12 '21 00:11 longemen3000

Hi!

That sounds great! Ask away and let's see what we can do.

moyner avatar Nov 15 '21 09:11 moyner

as for the Clapeyron integration, looking at the package code, the best course of action would be for us to add the package as a dependency, and try to make a two way integration, that is:

  • try to make that our models work with the flash methods in MultiComponentFlash.jl
  • try to make that the models in your package works with Clapeyron.jl properties

our cubics are not so fast (mainly because we need to allocate the alpha function to allow for different mixing schemes), and we don't have the Zudkevitch-Joffe EoS.

i will tag you on the corresponding PR, when i have something to show

longemen3000 avatar Dec 05 '21 03:12 longemen3000

with 1.9, i'm doing this as an extension. at the moment i'm working there: https://github.com/ClapeyronThermo/Clapeyron.jl/tree/multicomponentflash-ext

longemen3000 avatar Oct 20 '23 04:10 longemen3000

Extension sounds like a good idea. Thank you for the efforts!

moyner avatar Oct 20 '23 07:10 moyner