react-native-logs icon indicating copy to clipboard operation
react-native-logs copied to clipboard

fix(colors): update to use default colors

Open CoryWritesCode opened this issue 1 year ago • 3 comments

Adding default colors behaves the way it would seem when initially setting up the project. Let me know if this isn't something you want in here, it just seems like it should have defaults when you see the image initially and then set it up to see no colors out of the box.

image

fixes #95

CoryWritesCode avatar Apr 18 '24 19:04 CoryWritesCode

@alessandro-bottamedi this project still being maintained? See a few PRs need attention.

CoryWritesCode avatar Oct 10 '24 14:10 CoryWritesCode

Sorry, I’ve been very busy, but I’ll have time to check everything after October 15th! I’ll then release a new version with some of the PRs included…

alessandro-bottamedi avatar Oct 10 '24 15:10 alessandro-bottamedi

Hi, currently the colors are optional, messages are colored only if the colors option in the transport is filled in, also based on custom levels. I would prefer to leave it like this, maybe specifying it better in the readme? It seems cleaner to me to leave the transport options always empty by default... What's your opinion? @CoryWritesCode

alessandro-bottamedi avatar Oct 17 '24 09:10 alessandro-bottamedi

I think thats fine! It just didn't make sense to try what you mentioned in my Issue per the readme. The only issue I would think is that the first image of the lib shows colorization of the logs which made me think that it's available out of the box. So it should probably should be stated better in the readme at least.

CoryWritesCode avatar Nov 10 '24 03:11 CoryWritesCode