stormpy icon indicating copy to clipboard operation
stormpy copied to clipboard

Pass Storm location as HINT to CMake

Open volkm opened this issue 2 years ago • 2 comments

(Issue was originally raised in https://github.com/moves-rwth/stormpy/issues/28#issuecomment-1271835119)

Pass the Storm location (storm_dir ) as a HINT to CMake in https://github.com/moves-rwth/stormpy/blob/f19e657eec9cbb439a6934a3ea78a13cdba26d97/cmake/CMakeLists.txt#L3

volkm avatar Oct 10 '22 07:10 volkm

The path is currently already specified from setup.py via -Dstorm_DIR. Looking at the documentation, this is a valid option. We could switch to either explicitly providing hints or using -Dstorm_ROOT (see here).

volkm avatar Oct 10 '22 07:10 volkm

In general, I think the CMake part should already work as intended. It might be that the original issue in https://github.com/moves-rwth/stormpy/issues/28#issuecomment-1271810162 comes from a wrong configuration in setup.py. I did not look into it yet, but maybe the config from a pre-existing config file and the commandline arguments are conflicting.

volkm avatar Oct 10 '22 07:10 volkm

Implemented in https://github.com/moves-rwth/stormpy/pull/130.

volkm avatar Nov 10 '23 13:11 volkm