storm icon indicating copy to clipboard operation
storm copied to clipboard

Add::toMatrix and Add::toMatrixVector yield differently ordered SparseMatrices

Open tquatmann opened this issue 4 years ago • 0 comments

The matrices differ in the order of the rows within the rowGroups. While this is not a critical bug, such inconsistencies can lead to, e.g., unexpectedly different verification times. This is because Dds are traversed in different orders when InternalAdd::splitIntoGroups is invoked on either just a MatrixDd or a MatrixDd and an additional VectorDd. When (consistently) changing the traversal order to "first the THEN node, then the ELSE node", the GameBasedMdpModelCheckerTest no longer terminates (which could be an issue with mathsat, but has to be investigated further).

tquatmann avatar Mar 02 '20 05:03 tquatmann