storm icon indicating copy to clipboard operation
storm copied to clipboard

remove an instance of boost::any

Open sjunges opened this issue 1 year ago • 6 comments

sjunges avatar Dec 03 '23 20:12 sjunges

There was a problem with the ci and downloading boost.., but i cannot restart the CI @volkm

sjunges avatar Dec 03 '23 20:12 sjunges

I can rerun the jobs for some reason. Let's see whether it works the second time.

volkm avatar Dec 04 '23 08:12 volkm

I do not understand even remotely what happens here :/

sjunges avatar Dec 04 '23 14:12 sjunges

This line error: incomplete type 'std::is_copy_constructible<boost::optional<std::any> >' used in nested name specifier makes me think that boost::optional and std::any may not be compatible and that one has to use std::optional here.

sjunges avatar Dec 04 '23 16:12 sjunges

Given that this happens in Ubuntu 20.04, this could be a bug with, e.g., older boost versions.

Given that std::any can be uninitialised, the type boost::optional<std::any> does not make a lot of sense in the first place. We could simplify this to just std::any and use the has_value function.

tquatmann avatar Dec 05 '23 07:12 tquatmann

Agreed, thanks for the suggestion.

sjunges avatar Dec 06 '23 11:12 sjunges