Mouse
Mouse
> My master is pretty out of date because I don't use it Ah, OK. Good to know. > My changes are not specific to the S1AP protocol and they...
@velichkov OK, merged. My [vlm_master](https://github.com/mouse07410/asn1c/tree/vlm_master) now has your `s1ap`. I will let you and @brchiu know when I make it the "main" master of my fork.
Ha, you noticed. ;-) The difference you see contains: - a fix for comparison between signed and unsigned integers (flagged by Clang in Travis CI); - a fix for https://github.com/vlm/asn1c/issues/252...
> The `per_long_range_rebase()` function is performing some range checks that this fix does not, so this fix is not complete. Would you recommend then copying all (or most) of the...
@velichkov I hate to bother you, as you're already helping a lot - but would you mind taking a look at the [fix I applied to `skeletons/INTEGER.c`](https://github.com/mouse07410/asn1c/blob/vlm_master/skeletons/INTEGER.c#L775-L788), and comment on...
Thank you!
I like this PR, and it passes the CI - so I merged it into my fork. Thanks, @riebl
@velichkov do you have any idea why it would ever make sense to remove extensions if they were specified? @vlm any comment here? Thanks!
@brchiu the above seems to imply that the same ASN.1 file could produce encoding with member constraints either honored or dropped, depending on what format is used?
> According to my limited knowledge of APER implementation in #125, most of the changes reside in skeleton directory. After @vlm apply #186, which is a re-implementation of #143 and...