simpleheat icon indicating copy to clipboard operation
simpleheat copied to clipboard

Add guard around zero width or height

Open Bengreen opened this issue 7 years ago • 4 comments

in my usage of this via leaflet.heat I have a lifecycle where the canvas can be 0 width or 0 height which is causing getImageData to throw an error. I placed a guard around the relevant section so this case is covered. If you can accept this request I will contact the leaflet.heat upstream and ask for them to propagate the update to their release.

Bengreen avatar Nov 24 '17 11:11 Bengreen

Any feedback if this can be included ?

Bengreen avatar Feb 06 '18 15:02 Bengreen

This has been open for a long time, was it just an oversight?

Dumbaz avatar Jun 18 '20 10:06 Dumbaz

Hello, great plugin. Wondering if this is something that can be merged?

corrigancd avatar Nov 30 '20 10:11 corrigancd

Same issue here, is it going to be merged anytime soon?

victorperezpiqueras avatar May 10 '23 13:05 victorperezpiqueras