Volodymyr Agafonkin

Results 530 comments of Volodymyr Agafonkin

You might have more luck with https://github.com/abellgithub/delaunator-cpp, which is a more actively maintained port β€” this one seems to have been abandoned.

@wboykinm will do immediately after 0.7, which is soon.

@mrgreywater or maybe we should convert the fixtures to regular text files to avoid the json dependency?

> but we would then need to convert all fixtures whenever earcut.js is updated, which could be otherwise avoided. @mrgreywater (edit) I think using https://github.com/mapbox/earcut.hpp/blob/master/test/convert_tests.js isn't much of a hassle,...

> assuming we add the libtess deviation to the json files in earcut.js I don't want to care much about `libtess` in Earcut on the JS side, so I'd prefer...

Yeah, this library is designed specifically for valid polygon inputs without self-intersections, nested rings (beyond holes) etc. Handling more complex cases is a difficult problem and is out of scope...

Cool! Can you describe the logic in more detail here?

@finscn sorry, I didn't have the chance to thoroughly review it yet. It's on my list. Feel free to use your forked version in the mean time.

Is this behavior causing any particular issues? It seems like a result I would expect.