motorcycle.ts icon indicating copy to clipboard operation
motorcycle.ts copied to clipboard

Add return type for run

Open Frikki opened this issue 7 years ago • 2 comments

run is missing a return type: https://github.com/motorcyclets/motorcycle/blob/c58d6fdff986fe709c07022d6036a2f1ccb5b2da/packages/run/src/run.ts#L45

It returns { sinks, sources, dispose }. It should have a type, so it’s possible to talk about it’s type signature.

Frikki avatar Oct 28 '17 02:10 Frikki

I'm thinking the name IODisposable<Sources, Sinks> would be great for this. What do you think?

TylorS avatar Oct 31 '17 18:10 TylorS

Yes. I’m sold!

Frikki avatar Oct 31 '17 22:10 Frikki