Craig P. Motlin

Override Java 8 default methods for correctness and efficiency.

3

There are several default methods added to Java 8 collections interfaces that are not overridden in Eclipse Collections. Default methods are often composites that delegate to several other methods. For...

Investigate whether Collectors2AdditionalTest.sumBy*Parallel is thread-safe.

2

I saw this one-off error in Travis and I don't want to lose track of it. ``` 13:38:40:796 [ERROR] Tests run: 64, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:...

`Collectors.groupingBy()` has an overload which accepts another Collector, allowing multi-level groupBys. [This guide](http://www.baeldung.com/java-groupingby-collector) includes this example: ```java Map map = posts.stream() .collect(groupingBy(BlogPost::getAuthor, groupingBy(BlogPost::getType))); ``` RichIterable could have additional variants of...

Add information about compatible versions of node to the README.

1

I followed the instructions in [README.md](https://github.com/twosigma/git-meta/blob/master/README.md) and got a compiler error. I tried upgrading node to 11.x and then downgrading to 8.x and then it worked with 8.x. Assuming git-meta...

Add H2 test suite.

3

Stacked review of an H2 test suite.

Problem with attribute quoting in ddl generation for h2.

2

After upgrading to the latest version of Reladomo, I see the new attribute quoting behavior. I'm generating ddl files to disk using the postgres database type, and then I load...

Improve sql logging by adding additional context.

7

Reladomo's sql logging is so useful that I sometimes leave it turned on in production. ``` DEBUG com.gs.fw.common.mithra.sqllogs.MyClass: connection:1030722971 find with: select t0.key,t0.number from MY_CLASS t0 where t0.key = 'abcd'...

This pull request doesn't work yet. I'm sharing it for early feedback. I'll add comments inline to point out where I need help.

Same thing, but on the 1.2 branch.