Moti Zilberman
Moti Zilberman
One subtle issue with a generic solution is that `appr` invokes _two_ `exp` commands (`login` and `publish`), so forwarding to `publish` is not necessarily all anyone would need. Not sure...
I like `--exp-login-*` and `--exp-publish-*`, but I believe parsing these with parameters (which can be space-separated etc) would still require `appr` to know `exp`'s options schema. Maybe `EXP_PUBLISH_ARGS` and `EXP_LOGIN_ARGS`...
It would be awesome to still have some indication within the PR thread that the app has been updated, say with a comment that includes a timestamp, commit hash or...
@jayeszee FYI, tweaking `appr` to use `exp publish --max-workers=1` fixed a very similar problem I was having on Travis - see #32.
@huntie We can't use `react-native`, specifically - that key is already [used](https://github.com/react-native-community/cli/blob/58ca7f1cb430e6a909d4d10e944ae639102053e1/packages/cli-plugin-metro/src/tools/loadMetroConfig.ts#L92) as a React Native-specific variant of [`browser`](https://github.com/defunctzombie/package-browser-field-spec).
For the record, these are the changelogs for this Metro update: [0.73.0](https://github.com/facebook/metro/releases/tag/v0.73.0), [0.73.1](https://github.com/facebook/metro/releases/tag/v0.73.1), [0.73.2](https://github.com/facebook/metro/releases/tag/v0.73.2), [0.73.3](https://github.com/facebook/metro/releases/tag/v0.73.3) Ideally we should mention relevant items from the Metro changelog in the RN 71 changelog...
This is a few years old now, but as a data point, I've run into a case within Meta's codebase where the hardcoded list is problematic. In a part of...
@oluckyman I realise it's been a long time, but is there any chance you can elaborate on the behaviour you're seeing here? Particularly, I'm assuming `partly.js` is actually fixed in...
This should probably just work from anywhere inside a Git repo - I don't see a need for config really. Thoughts?
> this doesn't fix the non-symbolicated non-component stack traces I agree that solving for both makes the most sense. Showing a partially symbolicated trace feels broken. > Metro should symbolicate...