Moti Zilberman
Moti Zilberman
Is this an issue only when upgrading from an earlier version of React Native / Metro, or does this also reproduce when creating a new app based on the latest...
I think beyond this point I mainly want to spend some time on the DeltaCalculator tests and see if I can (1) simplify the mocking setup for the existing tests,...
I've come to believe we should merge the existing DeltaCalculator + traverseDependencies test suites. It can be done fairly mechanically by rewriting the traverseDependencies tests we have in terms of...
1. Does this repro in a fresh app created with the latest React Native release? 2. Alternatively, is there a link to a repo that shows this behaviour so that...
I agree that this needs to be fixed, but I don't think we should use a regex (or variable name matching in general) to do this as it's too brittle...
One practical and safe way we can do this is by passing the dependency map to the plugin and using it to understand that the `_$$_REQUIRE(_dependencyMap[4])` call evaluates to the...
At Meta, we've been using `experimentalImportSupport` in production for a few years. I think the main thing to consider at this point is how spec-compliant it is, and more to...
Hi @oblador, thanks for the PR! I completely agree that this is something we should improve, but I'm not sure the approach here is entirely correct. The `require` statements injected...
@mikeduminy One approach I have in mind is to add _dependency constraints_ to the output of the transformer. So when the transformer emits a `require('@babel/transform-helpers')` call assuming version `x.y.z`, it...
> I'm going to try using a quick fork of `appr` to validate that this completely solves the issue, will report back Update: Yep! Can't share my actual build log...