BanditPAM icon indicating copy to clipboard operation
BanditPAM copied to clipboard

Remove use of global in `KMedoids::fit`

Open motiwari opened this issue 4 years ago • 1 comments

this uses a global algorithm.

Instead, it should take an optional argument and pass it if necessary (or store the value as a member variable)

Similarly in https://github.com/ThrunGroup/BanditPAM/blob/67221ff929d8005e46358a9151795b66bce66891/src/kmedoids_algorithm.cpp#L294-L301

And https://github.com/ThrunGroup/BanditPAM/blob/67221ff929d8005e46358a9151795b66bce66891/src/kmedoids_algorithm.cpp#L89-L97

motiwari avatar Aug 04 '21 15:08 motiwari

Not fully resolved since global algorithm and some others used throughout

motiwari avatar Aug 17 '21 22:08 motiwari