motion
motion copied to clipboard
fix inertia: take care of the case when t is zero
This PR aims to fix an issue where Reorder.Item
randomly gets stuck as I posted here.
Related:
- https://github.com/framer/motion/issues/2101
- https://github.com/framer/motion/pull/2231
As noted here:
requestAnimationFrame timestamps can come through as lower than the startTime
which means that startTime
possibly can be equal to currentTime
and t
is 0 in that case. inertia
returns the state with done: true
in that case, and stops the animation immediately.
Is it possible to add a test on inertia
for this behaviour?
@mattgperry Thank you for your comment and indeed. Just addressed here. Please let me know!
Is there an update on this PR? Having issues with reorders as well
@ekatzenstein their is this PR #2231 waiting to be merged as well
Is there anything blocking getting this merged in? It seems like a high impact, edge case fix that includes a test
Shouldn't this be merged? It looks like a very simple fix that is tested. Or maybe I am missing something?
Is there an update on this? I'm also having similar issues with reordering
@mattgperry any chance we could have these 2 PRs merged please? The issue has been affecting our production for a while too
Seeing the recent activity, I am bringing this PR up again! @mattgperry it is the last brik to fix the re-order component that is broken!
Should this PR be merged or closed?
Closing as the added failing test was fixed by a update in the meantime (changing the >
on that line to a >=
)