Fix #36 - 'Attribute redefined' problem

[ciforusalterra]

I update this libs to fix Attribute Redefined problem on "xmlns:SOAP-ENV". We use different style configuration on our editor, so sorry for a lot of line arrangement. Thanks.

[moszeed]

Can you please fix those style quirks, there is a .eslint file you can use for this!

[ciforusalterra]

Can you please fix those style quirks, there is a .eslint file you can use for this!

I've already update it bro. Please check.

[moszeed]

thanks..

hmm, but there seems something wrong, the tests are failing: https://travis-ci.org/moszeed/easysoap/jobs/571747519

can you please check why !?

[ciforusalterra]

thanks..

hmm, but there seems something wrong, the tests are failing: https://travis-ci.org/moszeed/easysoap/jobs/571747519

can you please check why !?

It failed since I run test on your original source code. I don't have any idea for now.

[ciforusalterra]

thanks..

hmm, but there seems something wrong, the tests are failing: https://travis-ci.org/moszeed/easysoap/jobs/571747519

can you please check why !?

I've fix some of your test just to make it pass. I don't know if that was the correct behaviour.

[ciforusalterra]

Hi @moszeed, could you help me to merge this PR if there is no more issue? Our team need to use this libs as soon as possible. Thanks.

[3mp3ri0r]

Hi @moszeed. Are you still maintain this libs? How can we help you to maintain this repo?

[moszeed]

Hi, yes i still maintain this repo.. but in my spare time, so if you want to help, send small pull request, this one here has so many small changes (mostly style) that i have to check every thing...

so keep the styling as is ... 🙏

[3mp3ri0r]

We're already use your eslint config and that was the result. Any idea?

[ikonduktor]

You have error in your code. In file request.js

const envelope = await getRequestEnvelopeParams(combinedParams, opts); - returns xmlns:SOAP-ENV="${envelope.soap_env}"

and then you add this string one more time to

const $soapEnvelope = `<SOAP-ENV:Envelope
            xmlns:SOAP-ENV="${envelope.soap_env}"
            ${$namespacesAsString}>
            ${$head}
            ${$body}
        </SOAP-ENV:Envelope>`;

After that there is an error "Attribute redefined"