Moritz comments

Results 345 comments of


                                            Moritz

DateFormat('MMMM') outputs lowercase month names for some locales, inconsistent with English capitalization

I believe this is WAI - see https://st.unicode.org/cldr-apps/v#/fr/Gregorian/. Or do you have other information?

[record_use] Semantics: link hooks caching with recorded uses

I would prefer going with option 2 and keeping the filtering simple, for example specifying a list of annotations the linker depends on. 1 - Is a good choice for...

[package:intl] All DateFormat constructors require locale to be a nullable string

You can ignore the API leaks, that can be fixed in a different PR and not caused by this. For the version, I don't believe this is breaking as the...

[package:intl] All DateFormat constructors require locale to be a nullable string

All good - I will start merging, which is a bit of a complicated process for this package, as the source-of-truth is inside Google. So please be patient :)

[package:intl] All DateFormat constructors require locale to be a nullable string

All good!

Intl4x API refactorings.

> This PR is getting too big to review. I've spot-checked the tests, and found these two old comments from a previous review, but I'll let you merge this and...

Question: Where is the ARB schema officially published?

Very good question. Currently it is hosted here as the main source of truth. I was also thinking about re-activating https://github.com/google/app-resource-bundle to host a Dart package, a JS package etc....

Question: Where is the ARB schema officially published?

Yeah it makes sense to reactivate that repo. I will probably delete all the code inside it though, as it is unmaintained and thus dead.

Question: Where is the ARB schema officially published?

> Maybe move the schema to https://www.schemastore.org/json/? We should probably publish it there as well! I don't think we want the source of truth to be in a third party...