Mossroy

Remove usage of innerHTML of our code

38

It is currently the case in app.js and uiUtil.js, but it should be searched everywhere (excluding the third-party libraries like fontawesome or jquery). `.innerHTML` can be unsafe in terms of...

Libzim experiments

6

It uses the libzim only for getting content (articles and assets), but without setting the MIME type for now (because the C code does send this information for now) For...

Compile the libzim js bindings in a separate module

2

Like it is done for python : https://github.com/openzim/python-libzim/ It should be run by kiwix-build, too : see https://github.com/kiwix/kiwix-build/issues/503 It might allow this wasm version of libzim to be used in...

Libzim supports reading only chunks of data of a DirEntry : https://libzim.readthedocs.io/en/stable/api/classzim_1_1Item.html#_CPPv4NK3zim4Item7getDataE11offset_type9size_type This is something we are not able to do with our current custom javascript backend. Making use of...

Publish the docker image used to compile libzim with emscripten

3

In some docker registry. So that it's ready-to-use for developers on kiwix-js, without forcing them to build the image

Move source code for libzim wasm in kiwix-js repository

1

It's currently in https://github.com/mossroy/libzim_wasm Now that #513 is solved, we don't need to keep it separated any more, IMHO. It should be moved in this kiwix-js repo (probably in branch...

Read the ZIM file directly from the ServiceWorker

2

So far, it was impossible for a ServiceWorker to read the ZIM file directly. So we setup a MessageChannel with the main javascript thread, transfer the "request" to the main...

Remove the dependencies on the UI of js backend files

24

In zimArchive and zimArchiveLoader files, there are error cases where we display an error message to the user. It was initially done using `window.alert`, and is now done using `uiUtil.systemAlert`....

In app.js, there is some code that is always run on startup. Some of these steps might trigger an alert/confirm: 1. restore parameters from settingsStore 2. apply parameters from queryString...

Use regular expression literals when it's more readable

1

I had the habit (coming from other languages) to externalize regular expressions as variables created from a string, to make sure they were compiled once for all. But there seems...