Mossroy
Mossroy
It's still the case. I would probably need help from @mgautierfr to investigate with me. There must be something wrong in how we do that
> While we said we would not optimize jQuery mode any further, this looks like a bugfix. Recent Gutenberg ZIMs seem to rely on font files donwloaded form the ZIM...
To me, it's not the same situation as with the WebP polyfill. For WebP, the polyfill might not be present inside the ZIM file. Providing ours was a good way...
I did not check for Gutenberg but, usually, fonts are another type of file (not CSS) : .ttf, .woff and maybe other ones. In this case, what would be needed...
OK I now understand why you were mentioning CSS. You're right. But the first screenshot of the issue also shows missing .ttf and .woff files (maybe it's a different issue)
It's true that the usage we do of `.innerHTML` is probably not risky. But the automatic tools can not know that. Plus using `.textContent` is probably a bit faster (as...
Thanks @prsndp I've assigned it to you. Please read the CONTRIBUTING.md guidelines before creating a PR
You have to test your changes first, by running the app on your branch (see https://github.com/kiwix/kiwix-js/blob/master/CONTRIBUTING.md ). Did you already did that? Which tests did you do?
Check that you run the webserver from the root of the git repo (not from a subdir). That might be the reason. ServiceWorker mode should always work on http://localhost URLs
Please re-read completely the CONTRIBUTING.md file, where you should find your answer, and other important directions.