Simon Hoinkis

Results 66 comments of Simon Hoinkis

@MatthiasKillat Seems there is still a problem somewhere: 1) ~~The examples don't run~~ :heavy_check_mark: 2) ~~`MemoryProvider_Test.SegmentIdValueAfterCreationIsValid` is failing on some builds~~ :heavy_check_mark: You can have a look if you like....

> The first two commits can be squashed @dkroenke Typically, I prefer to keep separate things in separate commits, so you can later e.g. revert them individually with `git revert`....

@elfenpiff > Please add stack and variant queue to the Buffer table. :heavy_check_mark: I didn't add `VariantQueue` as it will be moved to `iceoryx_posh` soon and has variable attributes.

## Sync with @elBoberido and @elfenpiff How to proceeded further with the module structure? 1. Differentiation between user-view and iceoryx developer-view 1. First step: #1391 iceoryx developer-view aka new folder...

@elBoberido It might be confusing for developers browsing the repository on the first sight and might seem verbose to some. No hard feelings here, though. What do you think about?...

@elBoberido As this issue here is about the user-facing structure, let's move this discussion to #1391 and start implementing it next week once there is a decision.

@elfenpiff > `RelativePointer::get()` can return a `nullptr` > `operator->()` will always terminate when the relative pointer contains a `nullptr`. The reason is that when one accesses a `nullptr` via `operator->()`...

@saif-at-github There are some conflicts in `string_internal.hpp`. Could you please rebase onto `master`?

@saif-at-github I think you branched off a feature branch, I can see your `string` changes being included in this PR, too. I always try to start with a: ```bash git...

@saif-at-github FYI I'm doing a small bugfix in `cxx::unique_ptr` in #1685, this might affect some violations.