moss heim
moss heim
@lyxera yes that is true (see my comment on that issue). one of them should be closed.
It looks like brew has 17 for Intel, can you test with that? https://formulae.brew.sh/formula/clang-format#default You can get newer versions on Ubuntu very easily thru llvm's PPA: https://apt.llvm.org/
@capital-G Can you test with that version from brew or not? This would answer the main question. Then we can know if the version really matters or it's ok to...
100 lines of diff is very small all things considered, and the most common change seems to be adding a space after `//` which people should do anyway in new...
> I think if we decide to use a formatter it has to be deterministic, otherwise we will have arguments over formatting again and it can break CI, so we...
> I think this would be really beneficial for every contributor as now linting becomes completely automatic and already setup. Please let's keep this review conversation to just the clang-format...
> I reset to "before the formatting" and ran formatall with 14.0.1 but it now also inlined the changes - I really don't know whats the cause for the diff,...
> Isn't bumping the version going to cause the same issue later on? Perhaps reviewers could just use their judgement and recommend people format using clang, then, periodically (say once...
Not contributing to this project anymore, someone else can pick it up.
@prko I won't get to this anytime soon, if you need a quick review please find someone else to do it. :)