toolchains icon indicating copy to clipboard operation
toolchains copied to clipboard

Update adb to android sdk relative path

Open hsdk123 opened this issue 5 years ago • 3 comments

This just makes it more convenient in the event that adb isn't in one's path.

hsdk123 avatar Dec 31 '19 00:12 hsdk123

Same as with #11, right now I can't reliably verify this doesn't break existing uses where adb might be in a different location, so I'll have to postpone this until I have a real computer again.

mosra avatar Jan 01 '20 18:01 mosra

I should have switched branches when making this.. I'll close this for the moment and reopen later.

hsdk123 avatar Jan 04 '20 16:01 hsdk123

Finally merged the first commit (half-year delays, sorry).

Oh -- the rest is very cool. I'm interested in that also, so to avoid it getting lost/forgotten I'm reopening this PR. To make the change backwards-compatible I could imagine using cmake_parse_arguments() (which isn't in the minimal supported 3.4 yet, new in 3.5, but the Android toolchains requires 3.7 anyway, so that's okay) turning the function signature into for example (following the same format CMake is using in their docs):

android_create_apk(<target> <manifest> 
    [RESOURCES <res>] 
    [ASSETS <assets>])

If I get some time I can pick this up myself, just want to make sure this doesn't get forgotten :)

mosra avatar Jun 10 '20 16:06 mosra

The remaining TODO here -- passing paths to resources and assets -- is finally implemented in b3bd787dfec969ab2293def8ff8c021ce58ff44d and deccc401e2257d2766e717bc95d86aae2e897d6f, including proper dependency tracking for any files in given directories that either change, are added or are removed. Usage is as follows, I'll update the docs once I have confirmed that everything works as intended:

android_create_apk(<target> <manifest> 
    [RESOURCE_DIRECTORY <res>] 
    [ASSET_DIRECTORY <assets>])

mosra avatar Mar 22 '24 22:03 mosra