corrade icon indicating copy to clipboard operation
corrade copied to clipboard

Small micro-optimizations for Sha1

Open Squareys opened this issue 2 years ago • 2 comments

Hi @mosra,

as mentioned on gitter, here's the minor optimizations I did. The only really significant one is 3b0bce3352455e095bca9b2130dd0c5fada4472d, in case you want to cherry-pick it for minimal invasiveness.

Best, Jonathan

Squareys avatar May 26 '22 11:05 Squareys

(Argh, May last year and still not merged? What am I doing.)

Just FYI, I'm going to need fast hashing for image deduplication and so will get back to this soon. And with the Cpu library now being a thing and my new laptop implementing the x86 SHA instructions I'll be looking into making a proper implementation with competitive perf ;)

mosra avatar Jan 19 '23 16:01 mosra

No worries, we have since switched to xxhash3, which has insanely high throughput.

Squareys avatar Jan 21 '23 14:01 Squareys