pkg icon indicating copy to clipboard operation
pkg copied to clipboard

Add bufferchain for HTTP2 stream

Open peacocktrain opened this issue 5 years ago • 10 comments

Bufferchain is added for http2 stream and Iobuffer is implemented

peacocktrain avatar Nov 17 '20 07:11 peacocktrain

Codecov Report

Merging #23 (ea09cb0) into master (327992a) will increase coverage by 0.65%. The diff coverage is 50.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage   63.00%   63.65%   +0.65%     
==========================================
  Files          17       18       +1     
  Lines         819      908      +89     
==========================================
+ Hits          516      578      +62     
- Misses        248      276      +28     
+ Partials       55       54       -1     
Impacted Files Coverage Δ
buffer/bufferchain.go 50.87% <50.87%> (ø)
buffer/iobuffer.go 76.15% <0.00%> (-0.32%) :arrow_down:
log/errorlog.go 55.00% <0.00%> (ø)
log/logger.go 51.81% <0.00%> (+1.33%) :arrow_up:
log/roller.go 78.49% <0.00%> (+8.75%) :arrow_up:
utils/goroutine.go 92.30% <0.00%> (+23.07%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 327992a...ea09cb0. Read the comment docs.

codecov-io avatar Nov 17 '20 07:11 codecov-io

please fix the golang-ci lint warnings~

这个 PR 的背景和上下文是啥?

cch123 avatar Nov 17 '20 11:11 cch123

  1. 我看改动并没有更新依赖的地方,为什么更新了那么多依赖
  2. golint的报错都需要处理一下

nejisama avatar Dec 09 '20 06:12 nejisama

看了下是引入testify 导致的,pkg这个库 希望尽可能少的依赖,避免别的库引用的时候依赖过多,建议修改掉

nejisama avatar Dec 09 '20 08:12 nejisama

这个月不处理完,这个PR就关闭了哈

nejisama avatar Dec 22 '20 07:12 nejisama

这个PR 是为 http2 流式请求建立一个 bufferchain,downstream的buffer在这个队列中直接送到upstream消费

peacocktrain avatar Dec 28 '20 02:12 peacocktrain

这个pr能过,再更新修改mosnhttp2流式的哪个pr

peacocktrain avatar Dec 28 '20 02:12 peacocktrain

我看把vendor代码改了,但是go.sum没有改,应该不是正常的改动方式

nejisama avatar Dec 28 '20 06:12 nejisama

请按照标准流程来处理go.mod相关的文件

nejisama avatar Dec 28 '20 06:12 nejisama

请按照标准流程来处理go.mod相关的文件

go.sum 已回退

peacocktrain avatar Dec 28 '20 07:12 peacocktrain