layotto icon indicating copy to clipboard operation
layotto copied to clipboard

fix: restrict `secretFile` path

Open MichaelDeSteven opened this issue 3 years ago • 5 comments

What this PR does:

Which issue(s) this PR fixes:

Fixes #631

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


MichaelDeSteven avatar Jun 24 '22 09:06 MichaelDeSteven

Codecov Report

Merging #669 (e8e1103) into main (8aa188f) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #669   +/-   ##
=======================================
  Coverage   60.91%   60.91%           
=======================================
  Files         120      120           
  Lines        6389     6389           
=======================================
  Hits         3892     3892           
  Misses       2124     2124           
  Partials      373      373           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8aa188f...e8e1103. Read the comment docs.

codecov[bot] avatar Jun 24 '22 09:06 codecov[bot]

Well done! @ZLBer could u help review this PR?

seeflood avatar Jun 29 '22 00:06 seeflood

I submitted https://github.com/mosn/layotto/pull/698 to test the case ./layotto start -c and ./layotto start --config

@MichaelDeSteven Could u modify the quickstart doc to test the case 2 in https://github.com/mosn/layotto/issues/631

seeflood avatar Jul 06 '22 03:07 seeflood

I submitted #698 to test the case ./layotto start -c and ./layotto start --config

@MichaelDeSteven Could u modify the quickstart doc to test the case 2 in #631

I will modify and test it later.

MichaelDeSteven avatar Jul 06 '22 03:07 MichaelDeSteven

Hi @MichaelDeSteven , I submitted a PR https://github.com/MichaelDeSteven/layotto/pull/3 to your branch. It will test cases including:

  • ./layotto start without -c or --config flags.
  • case 2 in https://github.com/mosn/layotto/issues/631

Please review and merge :)

seeflood avatar Jul 07 '22 08:07 seeflood

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Aug 16 '22 03:08 github-actions[bot]

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Aug 23 '22 03:08 github-actions[bot]