layotto icon indicating copy to clipboard operation
layotto copied to clipboard

add comment to exported function/method/interface/variable

Open tianjipeng opened this issue 3 years ago • 8 comments

What would you like to be added: Add comment to exported function/method/interface/variable.

Why is this needed: There are many exported function/method/interface/variable that have no comment, it would be helpful if have comment.

tianjipeng avatar Jul 03 '21 17:07 tianjipeng

Thanks for your feedback! Lack of comments makes developers' experience very bad :< We will assign different tasks and ask the developers to add comments to their code. By the way,which part of code currently annoys you the most? We can add comments to that part first

seeflood avatar Jul 04 '21 04:07 seeflood

Considering that the workload of adding comments to all the modules is relatively large, we can split it into multiple tasks:

  • [x] add comments to RPC related code. See #230
  • [x] add comments to pubsub related code. https://github.com/mosn/layotto/pull/405
  • [x] add comments to lock related code. assigned to @LXPWing
  • [x] add comments to state API related code. assigned to @2019030007547
  • [x] add comments to actuator related code . assigned to @Holdonbei
  • [ ] add comments to tcpdump related code
  • [x] add comments to WASM related code . assigned to @LXPWing
  • [ ] add comments to flow-control related code
  • [x] add comments to configuration API related code

seeflood avatar Jul 04 '21 04:07 seeflood

hi,Can you leave this task “add comments to RPC related code” to me to complete

wudi-666272 avatar Sep 20 '21 06:09 wudi-666272

hi,Can you leave this task “add comments to RPC related code” to me to complete

Cool! Already assigned.Welcome to the Layotto Community and feel free to ask for help when u encounter problems.

seeflood avatar Sep 20 '21 06:09 seeflood

Hi,I want to try the task 'add comments to lock related code'

LXPWing avatar Oct 11 '21 07:10 LXPWing

@LXPWing Thanks for your passion!
I modified the tasks list above and the task 'add comments to lock related code' has been assigned to u. Sorry to reply so late,I was 7*24 oncall this week and too busy to check the github notification :(

seeflood avatar Oct 15 '21 12:10 seeflood

Recently learning WASM , I want to try the task 'add comments to WASM related code'

LXPWing avatar Dec 16 '21 14:12 LXPWing

Recently learning WASM , I want to try the task 'add comments to WASM related code'

Cool ! assigned to u

seeflood avatar Dec 16 '21 14:12 seeflood

/good-first-issue cancel /help-wanted cancel

Xunzhuo avatar Mar 06 '23 05:03 Xunzhuo

您的邮件我已收到。

Holdonbei avatar Mar 06 '23 05:03 Holdonbei

This issue has been automatically marked as stale because it has not had recent activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue or help wanted) or other activity occurs. Thank you for your contributions.

github-actions[bot] avatar Apr 07 '23 02:04 github-actions[bot]

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as pinned, good first issue or help wanted. Thank you for your contributions.

github-actions[bot] avatar Apr 15 '23 02:04 github-actions[bot]