foyer icon indicating copy to clipboard operation
foyer copied to clipboard

Replace `pkg_resources` with `importlib` and add python 3.13 to test suite.

Open chrisjonesBSU opened this issue 1 year ago • 4 comments
trafficstars

PR Summary:

I'm trying to fix some of the deprecation errors we're getting in the mosdef packages. One of them is coming from foyer with the use of pkg_resources.

pkg_resources will be removed in python 3.13

Note: This PR is not compatible with python 3.9, so we can't merge it until we want to drop 3.9 support and add 3.13.

PR Checklist


  • [ ] Includes appropriate unit test(s)
  • [ ] Appropriate docstring(s) are added/updated
  • [ ] Code is (approximately) PEP8 compliant
  • [ ] Issue(s) raised/addressed?

chrisjonesBSU avatar Jul 13 '24 09:07 chrisjonesBSU

It looks like the entry points methods in python 3.9 is different from python >= 3.10. So, that means we can't support both 3.9 and 3.13 whenever it's released. We can table these changes until we're ready to move on to python >= 3.10.

chrisjonesBSU avatar Jul 14 '24 08:07 chrisjonesBSU

Codecov Report

:x: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 62.02%. Comparing base (b002133) to head (1f34041). :warning: Report is 83 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #574   +/-   ##
=======================================
  Coverage   62.02%   62.02%           
=======================================
  Files          16       16           
  Lines        1667     1667           
=======================================
  Hits         1034     1034           
  Misses        633      633           
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Aug 19 '24 18:08 codecov[bot]

I don't think it's necessarily the right call here, but we could opt for using from platform import python_version to handle the differentiation from python 3.9-3.13 in this PR. Only if we didn't want to wait until we have to fully drop 3.9 to merge this PR.

CalCraven avatar Aug 30 '24 13:08 CalCraven

I don't think it's necessarily the right call here, but we could opt for using from platform import python_version to handle the differentiation from python 3.9-3.13 in this PR. Only if we didn't want to wait until we have to fully drop 3.9 to merge this PR.

I say we just wait. Maybe at the next dev meeting we can start talking about the plan to drop 3.9 and add 3.13, which will be officially released next month I believe.

chrisjonesBSU avatar Sep 05 '24 21:09 chrisjonesBSU

I guess we should probably wait until later this Spring for this? The final support for 3.9 is October 2025. https://peps.python.org/pep-0596/#lifespan

CalCraven avatar Dec 25 '24 13:12 CalCraven