foyer icon indicating copy to clipboard operation
foyer copied to clipboard

Drop Python 3.7

Open mattwthompson opened this issue 2 years ago • 3 comments

PR Summary:

You might want to consider dropping Python 3.7 as it's out of date with much of the rest of the ecosystem. I also took the liberty of ditching a few files that probably aren't used anymore.

PR Checklist


  • [ ] Includes appropriate unit test(s)
  • [ ] Appropriate docstring(s) are added/updated
  • [ ] Code is (approximately) PEP8 compliant
  • [ ] Issue(s) raised/addressed?

mattwthompson avatar Aug 31 '22 04:08 mattwthompson

I agree with dropping python 3.7, I think we bumped into that issue not long ago with unyt dropping 3.7 in their latest release. Currently, it looks like the test is failing on py3.10 build but I am not sure what's causing that still.

daico007 avatar Aug 31 '22 17:08 daico007

Currently, it looks like the test is failing on py3.10 build but I am not sure what's causing that still.

Micromamba complained about not finding an OpenMM build on Windows. That sounds plausibly a source of confusion I don't want to deal with here, so I've just dropped it.

mattwthompson avatar Aug 31 '22 17:08 mattwthompson

Codecov Report

Merging #513 (7735fec) into main (25a5fac) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #513   +/-   ##
=======================================
  Coverage   70.84%   70.84%           
=======================================
  Files          16       16           
  Lines        1650     1650           
=======================================
  Hits         1169     1169           
  Misses        481      481           

codecov[bot] avatar Aug 31 '22 18:08 codecov[bot]