streaming icon indicating copy to clipboard operation
streaming copied to clipboard

Shared lock

Open knighton opened this issue 1 year ago • 0 comments

Description of changes:

Implement a shared lock.

  • 25x faster than FileLock
  • No filesystem cleanup afterward
  • Lives in a few bytes of shared memory
  • Uses pthread_mutexattr_setpshared

Issue #, if available:

Merge Checklist:

Put an x without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • [ ] I have read the contributor guidelines
  • [ ] This is a documentation change or typo fix. If so, skip the rest of this checklist.
  • [ ] I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the MosaicML team.
  • [ ] I have updated any necessary documentation, including README and API docs (if appropriate).

Tests

  • [ ] I ran pre-commit on my change. (check out the pre-commit section of prerequisites)
  • [ ] I have added tests that prove my fix is effective or that my feature works (if appropriate).
  • [ ] I ran the tests locally to make sure it pass. (check out testing)
  • [ ] I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes.

knighton avatar Apr 29 '23 15:04 knighton